From 1139551fde4c1be76d181bbdf2a80c3649d0dd67 Mon Sep 17 00:00:00 2001 From: Frantisek Hrbata Date: Mon, 29 Sep 2025 15:22:33 +0200 Subject: [PATCH] fix(test_build_system): disable tests related to outside component dependencies The commit adb2d5deeebe ("feat(cmake): Produce warnings when component dependen..") introduced additional checks for source files and include directories used by a component that are located outside the component's directory. If these files and directories belong to another component, a warning is issued. This feature has not yet been implemented in cmakev2, so related tests are temporary disabled. Signed-off-by: Frantisek Hrbata --- tools/test_build_system/test_components.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/test_build_system/test_components.py b/tools/test_build_system/test_components.py index 9828bec316..a0258ec6fd 100644 --- a/tools/test_build_system/test_components.py +++ b/tools/test_build_system/test_components.py @@ -336,6 +336,7 @@ def test_unknown_component_error(idf_py: IdfPyFunc, test_app_copy: Path) -> None assert "Failed to resolve component 'unknown'" in ret.stderr +@pytest.mark.buildv2_skip('not yet implemented in cmakev2') def test_component_with_improper_dependency(idf_py: IdfPyFunc, test_app_copy: Path) -> None: # test for __component_validation_check_include_dirs and __component_validation_check_sources # Checks that the following warnings are produced: @@ -376,6 +377,7 @@ def test_component_with_improper_dependency(idf_py: IdfPyFunc, test_app_copy: Pa assert re_source.search(ret.stderr) is not None, f'Expected source file warning not found in: {ret.stderr}' +@pytest.mark.buildv2_skip('not yet implemented in cmakev2') def test_component_validation_not_run_in_subprojects(idf_py: IdfPyFunc, test_app_copy: Path) -> None: # test that component validation doesn't run in subprojects like bootloader logging.info('Check that component validation warnings are not shown in subprojects') @@ -417,6 +419,7 @@ def test_component_validation_not_run_in_subprojects(idf_py: IdfPyFunc, test_app assert ret.returncode == 0, 'Build should complete successfully with validation warnings' +@pytest.mark.buildv2_skip('not yet implemented in cmakev2') def test_component_validation_private_include_dirs(idf_py: IdfPyFunc, test_app_copy: Path) -> None: # test that component validation works for private include directories logging.info('Check that component validation warnings are shown for private include directories') @@ -447,6 +450,7 @@ def test_component_validation_private_include_dirs(idf_py: IdfPyFunc, test_app_c ) +@pytest.mark.buildv2_skip('not yet implemented in cmakev2') def test_component_validation_finds_right_component(idf_py: IdfPyFunc, test_app_copy: Path) -> None: # test that __component_validation_get_component_for_path finds the correct component for a given path #