From 51f3c021158d303b22ebd8a2869e080dd92aa7fd Mon Sep 17 00:00:00 2001 From: Vincent-Dalstra <51883563+Vincent-Dalstra@users.noreply.github.com> Date: Wed, 17 Sep 2025 14:48:39 +0800 Subject: [PATCH] Add quotes around node ID in dependency graph Graphviz node ID's are represented as strings, that can only use a restricted set of characters (characters, digits, and underscores), and must not match a reserved keyword. These restrictions do not apply when the string is wrapped in double quotes. This allows for component names with dashes in them, for example. --- tools/cmake/depgraph.cmake | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/cmake/depgraph.cmake b/tools/cmake/depgraph.cmake index fc312db7ad..9e80666265 100644 --- a/tools/cmake/depgraph.cmake +++ b/tools/cmake/depgraph.cmake @@ -35,10 +35,10 @@ function(depgraph_add_edge dep_from dep_to) # However, show which components are "common" by adding an edge from a node named "common". # If necessary, add a new build property to customize this behavior. if(NOT dep_from IN_LIST common_reqs) - idf_build_set_property(__BUILD_COMPONENT_DEPGRAPH "common -> ${dep_to}" APPEND) + idf_build_set_property(__BUILD_COMPONENT_DEPGRAPH "\"common\" -> \"${dep_to}\"" APPEND) endif() else() - idf_build_set_property(__BUILD_COMPONENT_DEPGRAPH "${dep_from} -> ${dep_to} ${attr}" APPEND) + idf_build_set_property(__BUILD_COMPONENT_DEPGRAPH "\"${dep_from}\" -> \"${dep_to}\" ${attr}" APPEND) endif() endfunction()