alex/esp-idf
1
0
Fork 0
mirror of https://github.com/espressif/esp-idf.git synced 2025-11-18 10:31:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(esp_http_client): Fix OTA failure with partial download enabled

Browse Source 
This commit fixes an issue encountered during OTA when partial download
is enabled using an AWS signed URL restricted to GET requests.
It also adds an API to retrieve the OTA image size from the Content-Range header.
This commit is contained in:
nilesh.kale
2025-05-20 11:05:42 +05:30
parent 3e46a73964
commit caf828dfaf
5 changed files with 78 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
components/esp_http_client/esp_http_client.c
View File

@@ -67,6 +67,7 @@ typedef struct {
int64_t data_process; /*!< data processed */
int method; /*!< http method */
bool is_chunked;
int64_t content_range; /*!< content range */
} esp_http_data_t;
typedef struct {
@@ -269,7 +270,29 @@ static int http_on_header_value(http_parser *parser, const char *at, size_t leng
if (client->current_header_key == NULL) {
return 0;
}
if (strcasecmp(client->current_header_key, "Location") == 0) {
if (strcasecmp(client->current_header_key, "Content-Range") == 0) {
HTTP_RET_ON_FALSE_DBG(http_utils_append_string(&client->current_header_value, at, length), -1, TAG, "Failed to append string");
int64_t total_size = -1;
client->response->content_range = -1;
char *slash_pos = strchr(client->current_header_value, '/');
if (slash_pos) {
if (slash_pos[1] == '*') {
ESP_LOGE(TAG, "Content-Range header has unknown total size (bytes A-B/*)");
} else {
char *endptr;
total_size = strtol(slash_pos + 1, &endptr, 10);
if (total_size > 0 && *endptr == '\0') {
client->response->content_range = total_size;
} else {
ESP_LOGE(TAG, "Failed to extract total size from Content-Range");
}
}
} else {
ESP_LOGE(TAG, "Invalid Content-Range format (missing '/')");
}
} else if (strcasecmp(client->current_header_key, "Location") == 0) {
HTTP_RET_ON_FALSE_DBG(http_utils_append_string(&client->location, at, length), -1, TAG, "Failed to append string");
} else if (strcasecmp(client->current_header_key, "Transfer-Encoding") == 0
&& memcmp(at, "chunked", length) == 0) {
@@ -1817,6 +1840,11 @@ int64_t esp_http_client_get_content_length(esp_http_client_handle_t client)
return client->response->content_length;
}
int64_t esp_http_client_get_content_range(esp_http_client_handle_t client)
{
return client->response->content_range;
}
bool esp_http_client_is_chunked_response(esp_http_client_handle_t client)
{
return client->response->is_chunked;