alex/esp-idf
1
0
Fork 0
mirror of https://github.com/espressif/esp-idf.git synced 2025-09-01 06:27:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(esp_http_client): fix possible double memory free

Browse Source
This commit is contained in:
Ashish Sharma
2025-08-01 11:44:06 +08:00
parent 0c4a4ef019
commit ed9266b194
1 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
components/esp_http_client/lib/http_utils.c
View File

@@ -65,15 +65,8 @@ char *http_utils_append_string(char **str, const char *new_str, int len)
}
if (old_str) {
old_len = strlen(old_str);
// old_str should not be reallocated directly, as in case of memory exhaustion,
// it will be lost and we will not be able to free it.
char *tmp = realloc(old_str, old_len + l + 1);
if (tmp == NULL) {
free(old_str);
old_str = NULL;
ESP_RETURN_ON_FALSE(old_str, NULL, "http_utils", "Memory exhausted");
}
old_str = tmp;
old_str = realloc(old_str, old_len + l + 1);
mem_check(old_str);
// Ensure the new string is null-terminated
old_str[old_len + l] = 0;
} else {