mirror of
https://github.com/espressif/esp-idf.git
synced 2025-08-12 13:27:36 +00:00
3948949019
The C17 standard (sec 6.7.2.2) indicates that the underlying type of an enum is implementation defined (i.e., can be signed or unsigned). Thus, comparing "-1 >= some_enum" where "some_enum" is always 0 or largert can return true if the compiler uses unsigned for enums. This commit fixes the following issues with ana_cmpr: - Fixed incorrect comparison in ana_cmpr_del_unit() that relied on enums being signed, thus would always return true. - Fixed incorrect expected argument in the "ana_cmpr_unit_install_uninstall" test. This was not picked up due to the incorrect enum comparison above.