mirror of
https://github.com/espressif/esp-idf.git
synced 2025-11-04 06:11:06 +00:00
24c20d188e
...and all their callers. With the upcoming switch from sizeof(time_t)==4 to sizeof(time_t)==8, sizeof(struct stat) is also increasing. A few newlib functions present in ROM allocate 'struct stat' on the stack and call _fstat_r on this structure. The implementation of fstat is provided in ESP-IDF. This implementation will often do memset(st, 0, sizeof(*st)), where st is 'struct stat*', before setting some fields of this structure. If IDF is built with sizeof(st) different from sizeof(st) which ROM was built with, this will lead to an out-of-bounds write and a stack corruption. This commit removes problematic ROM functions from the linker script. Here are the functions which allocate 'struct stat': * _isatty_r (in ROM) * __swhatbuf_r, called by __smakebuf_r, called by __swsetup_r and __srefill_r (in ROM) * _fseeko_r (not in ROM) * glob2 (not in ROM) * _gettemp (not in ROM) As a result, these functions are used from libc.a, and use correct size of 'stat' structure. Closes https://github.com/espressif/esp-idf/issues/7980
16 lines
576 B
Plaintext
16 lines
576 B
Plaintext
/*
|
|
* SPDX-FileCopyrightText: 2022 Espressif Systems (Shanghai) CO LTD
|
|
*
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
/* These are the newlib functions and the .bss/.data symbols which are related to 'time_t'
|
|
or other structures which include 'time_t' (like 'struct stat').
|
|
These ROM functions were compiled with sizeof(time_t) == 4.
|
|
When compiling with sizeof(time_t) == 8, these functions should be excluded from the build.
|
|
*/
|
|
|
|
_isatty_r = 0x4000126c;
|
|
PROVIDE( __smakebuf_r = 0x40001530 );
|
|
PROVIDE( __swsetup_r = 0x40001560 );
|
|
PROVIDE( __swhatbuf_r = 0x4000153c );
|